timber/starter-theme

Issue with 2.0 theme after most recent folder restructuring

dreamersofdreams opened this issue · 5 comments

Have been doing a lot of local testing recently with starter theme 2.0. Was running great until I just tried implementing these recent updates #139

Just a blank screen - no error message.

Spun up a fresh new local site with Starter theme 2.0 (with those changes from #139) and same thing - just blank white screen. Will try and do some more troubleshooting, but just throwing out there now since this just got implemented yesterday...

Just a quick follow up: On my fresh install, I just reverted everything back - moved everything back into a "theme" folder and then reverted the functions.php and test-timber-starter-theme.php file back to how it was before the #139 merge. And everything worked again... So I'm guessing that perhaps there may still be something trying to point to "theme" directory?
Have no idea what that test-timber-starter-theme.php file actually does, however, there is still a reference to the /theme directory...
switch_theme( basename( dirname( DIR ) ) . '/theme' );
Just a hunch.

The problem may be here, this line has not been reverted

Timber::$dirname = array( '../views' );

was

Timber::$dirname = array( 'templates', 'views' );

@szepeviktor Yep that was it - thanks for catching! So that'll need to be updated in main 2.0 branch.

gchtr commented

Thanks for reporting this and for the solution. I may have merged that pull request too early. I tried to fix the automated test after that, but couldn’t finish before the weekend.

We’ll bring the tests back in #142 together with a fix for this.

Should be fixed, closing