timber/starter-theme

TODO's after Timber 2.0

Levdbas opened this issue · 4 comments

Levdbas commented

Now Timber 2.0 is released I went though this repo and written down the things that could use some love. I could create a PR for 1,2, 4,5 and cleanup the issues if I can get access to this repo as well :)

  • update readme file, it still suggests the plugin.
  • update examples in readme. Some are very old.
  • maybe create a release or remove older releases.
  • is this file needed at all? https://github.com/timber/starter-theme/blob/2.x/views/page-plugin.twig
  • cleanup issues in repo
  • Adding a license?
  • Adding coding standard
  • Applying coding standard after merges
  • Fix PHPstan issues after merges
  • Overhauling the starter site class
  • PSR autoloading
  • CI: auto run PHPCS and PHPUNIT
  • Update minimal PHP version to 8.1 in PHP unit tests and phpstan/phpcs
szepeviktor commented

Maybe choosing a coding standard?

gchtr commented

@Levdbas I just invited you as a maintainer, so I’d be happy if you could work on that list of issues. I have nothing to add ad the moment.

You can find the relevant information here:

starter-theme/footer.php

Lines 2 to 7 in 8d4f39c

/**
* Third party plugins that hijack the theme will call wp_footer() to get the footer template.
* We use this to end our output buffer (started in header.php) and render into the view/page-plugin.twig template.
*
* If you're not using a plugin that requries this behavior (ones that do include Events Calendar Pro and
* WooCommerce) you can delete this file and header.php

  • 🎉1
Levdbas commented

Hi @gchtr and @szepeviktor , A bunch of PR's have been created as a staring point for making the starter theme a bit more modern. I would like to have both your feedback if possible. Looking forward to the collaboration!