Cannot create metric view when there's a tag with key `series`

When creating the view for a metric the following function is called with the label_key as argument:

promscale_extension/migration/idempotent/001-base.sql

Line 2425 in 9db8b90

    
           CREATE OR REPLACE FUNCTION _prom_catalog.get_label_key_column_name_for_view(label_key text, id BOOLEAN)

The label_key is checked against some reserved keys, if there's a match then the key is prepended with label_:

promscale_extension/migration/idempotent/001-base.sql

Lines 2433 to 2438 in 9db8b90

    
           SELECT label_key = ANY(ARRAY['time', 'value', 'series_id', 'labels']) 
        
           INTO STRICT is_reserved; 
        
           IF is_reserved THEN 
        
             label_key := 'label_' || label_key; 
        
           END IF;

If the key is series it won't match series_id and pass the check. The problem is that if the key is an id (second parameter of the function) we call:

promscale_extension/migration/idempotent/001-base.sql

Line 2441 in 9db8b90

RETURN (_prom_catalog.get_or_create_label_key(label_key)).id_column_name;

Which returns series_id and creates the conflict:

promscale_extension/migration/idempotent/001-base.sql

Line 615 in 9db8b90

_prom_catalog.pg_name_unique(new_key || '_id', format('%s_id', new_id))

This was reported by one of our users timescale/promscale#1685

	SELECT label_key = ANY(ARRAY['time', 'value', 'series_id', 'labels'])
	INTO STRICT is_reserved;

	IF is_reserved THEN
	label_key := 'label_' \|\| label_key;
	END IF;