Polish the external API
Closed this issue · 1 comments
timgent commented
Issues identified so far:
- No need for QualityChecker object - should just be able to run a CheckSuite directly - MR created
- Remove QualityChecker
- Pass in qcResultsRepository directly to a ChecksSuite instead
- Persist QC Results in the ChecksSuite.run method
- Could RawCheckResult be a bit neater or more nicely named? - I still can't come up with anything nicer at the moment...
- Make MetricComparator curried for neater syntax - Can't do this without breaking case class. Additional constructor results in double definition error, which I can only find ugly workaround for. Just going to have to live with this for now
timgent commented
Done