[BUG] Device name in popup is mismatched with the device

Question

[BUG] Device name in popup is mismatched with the device

sidevesh opened this issue 8 months ago · 4 comments

The device name in the popup seems to be composed of USERNAME's followed by the model name,
but the username it gets is the shortname used by user's dir and not the full name specified in User settings,
which looks odd,

I think we should just show the device's bluetooth name here since when Galaxy Buds are paired with a Samsung phone,
they rename themselves to 'User's Galaxy Buds' anyways as you can see in the screenshot.

Answer 1 · 2024-02-12T17:39:54.000Z

@ThePBone do lmk your thoughts on this, I can take a look at implementing this.

Answer 2 · 2024-02-14T12:58:45.000Z

Sure, feel free to take a look at this. Sounds like the easiest way to solve it.

Answer 3 · 2024-02-14T16:23:51.000Z

I did, I couldnt find the function in the BluetoothImpl that returns the device name, could you point me to it in case I missed it ?

Answer 4 · 2024-02-16T16:51:11.000Z

Yep, you're right. It hasn't kept track of the real device name until now.

I changed that in commit dd87a0b. I've only tested it on Linux so far, but it should work with the Bluetooth backends for the other platforms, too.