Image2disk workflow swallows errors
Closed this issue · 1 comments
moadqassem commented
image2disk workflow swallows some of the errors which are returned once the workflow is executed.
Expected Behaviour
When an error occurs, it should be printed out in the logs
Current Behaviour
No error is being printed out.
Possible Solution
Add the errors in the fmt.Errorf() function
Steps to Reproduce (for bugs)
1.Run the workflow
2.If an error has been encountered during partitions re-probing, error message won't be there
3.
4.
Context
Your Environment
- Operating System and version (e.g. Linux, Windows, MacOS):
OSIE - How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:
OnPrem - Link to your project or a code example to reproduce issue:
moadqassem commented
FYI, here is the PR for the fix #40