tinkerbell/actions

Tag the released images in this repository

rgl opened this issue · 4 comments

rgl commented

Its quite hard to go from a image, say, image2disk:v1.0.0 to its source code, as there are no tags in this repository nor a git revision in the artifacthub page.

Can these be included in the release process?

tstromberg commented

Discussed at triage:

  • We could add Github tags for each image released, say image2disk-v1.0.0
  • We could also add a commit label for each image released, say 0eaf0ebc

Thoughts?

rgl commented

Both sound good! :-)

nshalman commented

It seems like if commits land and the README.md hasn't been updated, a new container reusing the same version string and thus the same tag will be pushed to quay. So there's no enforcement preventing us from pushing new containers with the same version string. (Also, per #69, other stuff may not be quite right with the release process.)

Example of container tag advancing repeatedly: https://quay.io/repository/tinkerbell-actions/image2disk?tab=history

Discussed again during triage. Possible plan of action (CC @mmlb):

  • Add CI checks that enforce version updates in README.md when code changes.
  • Push image tags that directly reference the git commit ID
  • Push semver style tags so that users can get updated images easily.
chrisdoherty4 commented

Obsolete