tinkerbell/charts

tink-stack relay container starts when relay is false

Closed this issue · 0 comments

sepauli commented

Expected Behaviour

The relay container in the tink-stack pod shouldn't start if stack.relay.enabled: false

Current Behaviour

The relay container in the tink-stack pod starts also if stack.relay.enabled: false

Possible Solution

add an if-end block in stack/templates/nginx.yaml and check if stack.relay.enabled is true

I have already created a branch and fixed the helm-templating at the point that the container does not start if relay.enabled is set to false.

However, I am not 100% sure whether the container is still needed.
If I'm right, I can open a PR

Steps to Reproduce (for bugs)

  1. set the configuration
  relay:
    name: dhcp-relay
    enabled: true
  1. deploy the stack
  2. check the tink-stack pod
  Warning  BackOff    18s (x6 over 71s)  kubelet            Back-off restarting failed container dhcp-relay in pod tink-stack-7b8c7c65f9-zzjnx_tink-system(e3bf4bd1-636d-488b-9c3b-41e840528fe3)

Your Environment

RKE2 3-Node cluster

  • Operating System and version (e.g. Linux, Windows, MacOS):
    Ubuntu 24.04

  • How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:
    On Baremetal Servers