Task Spec should define a `machineRef` not a `connection`
Opened this issue · 3 comments
The Task spec currently doesn't allow referencing a machine but requires the full connection details. Tasks should not require the full connection details. It should instead reference a machine like the Job spec does.
Expected Behaviour
Current Behaviour
Possible Solution
Steps to Reproduce (for bugs)
Context
Your Environment
-
Operating System and version (e.g. Linux, Windows, MacOS):
-
How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:
-
Link to your project or a code example to reproduce issue:
This was by design, though I don't recall the details. What's the motivation to change it?
The UX of jobs is nice. I dont need to add connection details per job. I could see the util in keeping the connection object in a task so that one off tasks can be defined without needing to have a machine CR or before one is created. But once a machine CR exists, having to define the connection details for every tasks is not ideal. Maybe tasks could take either a machine ref or connection details.
A mutually exclusive field with the connection
field sounds quite flexible; I'd probably be in favor of that.