tipsy/profile-summary-for-github

Caching parameters are for MySQL not H2

brettwooldridge opened this issue · 2 comments

I noticed that the caching parameters are copy-pasted from the HikariCP example initialization code, and as a result the caching parameters are relavent for MySQL, not H2.

addDataSourceProperty("cachePrepStmts", "true")
addDataSourceProperty("prepStmtCacheSize", "250")
addDataSourceProperty("prepStmtCacheSqlLimit", "2048")

Documentation for available H2 properties is here:
https://www.h2database.com/javadoc/org/h2/engine/DbSettings.html#queryCacheSize

According to those docs, enabling statement caching would look like this:

private const val urlToDb = "jdbc:h2:mem:userinfo;QUERY_CACHE_SIZE=250"

(I am the author of HikariCP)

Good catch, thank you! Will correct this shortly

tipsy commented

Thanks @brettwooldridge! (also thank you for HikariCP, I use it a lot)