updating to 2.7 forces to change the app language to chinese and there's no way to change it back to english.
Closed this issue · 14 comments
Please confirm the following:
- Be sure to check out FAQ
- I have carefully read the README
- I have searched through the issues page but couldn't find a solution.(Including issue that has been closed)
- Easydict has been upgraded to the latest version
- I understand and agree to the above, and understand that the project maintainer has limited energy, issues that do not follow the rules may be ignored or closed directly
Problem description
updating to 2.7 forces to change the app language to chinese and there's no way to change it back to english.
Is the issue consistently reproducible?
Reproducible
Steps to Reproduce
just update it
Screenshot
Expected result
I want it to be in english!
Proposed solution (optional)
No response
Device type and OS version
apple m2 air, sonoma
Are you willing to submit a PR to fix this issue?
- I'm willing to submit a PR
Hello hyperphysin, Thank you for your first issue contribution 🎉
@choykarl If you have time, please take a look at this issue and see if it modifies the user's App language?
Hey, @tisfeng! I have the same issue @choykarl does.
The thing is the settings page looks nothing like the one in your screenshot. It never did look that way for me in previous versions either. It always looked like this:
And there doesn't seem to be an option to change the interface language. In your screenshot it's directly above the appearance setting, while there is nothing above the "外观" setting in the layout I happen to have.
I am very much confused, honestly ((
We rewrote the settings page using SwiftUI and added many new features, such as app language switching, but this part of SwiftUI functionality requires macOS 13.0+.
If your computer system is macOS 13.0+, the settings page will have the SwiftUI App option. Please enable it and then restart Easydict.
Hey, @tisfeng! Thanks for the reply!
I've switched to the SwiftUI version, it launched in Chinese, but the settings pane became just like in your screenshot, the language switch was right there, and everything is quite perfect now. Thank you!
Except for one minor thing. I use AltTab window switcher instead of macOS' built-in one. It mimics the way window switching works in Windows listing all the apps' windows instead of switching between apps. And while there is nothing unusual to be seen in Mission Control, AltTab's window switching pane shows a stray faceless window called "Go to Settings" and carrying EasyDict's icon. It's there whenever ED is running: I quit it — the window goes away; launch it again — it reappears.
Could you please look into this?
Thank you so much for your hard work!
I've looked a bit closer, and it's not just AltTab. The stray interface-less Easydict window is there in Mission Control as well. Admittedly, you have to look for it, but it is there, and for no good reason.
Thanks for your feedback, I checked the code and it is indeed a bug, we will fix it later.
The problem is probably caused by this code.
@AkaShark Could you take a look at it?
Easydict/Easydict/App/EasydictApp.swift
Line 59 in d6d04b1
The problem is probably caused by this code.该问题可能是由这段代码引起的。
@AkaShark Could you take a look at it? 你能看一下吗?
Easydict/Easydict/App/EasydictApp.swift
Line 59 in d6d04b1
Sure, I'll check the code later.