Enhancement and Format Incompatibility Fix: Aesthetic Improvement and Image Format Compatibility
Opened this issue · 0 comments
Description
I would like to propose two changes that enhance the user experience and address an issue faced by students when applying for the GitHub student package with their digital ID. These changes are implemented on separate branches and require review and feedback.
First Fix: Aesthetic Enhancement (Branch: aesthetic-enhancement)
Description: The first fix is an aesthetic enhancement on the CSS file, improving the overall visual appeal of the page.
Changes made: The page has been centralized, providing a more balanced layout. Additionally, I made the border-radius of "main" element visible, which adds a more polished look.
Pull Request: Link to the first pull request
See screenshots below:
- Before aesthetics enhancement
- After aesthetics enhancement
Second Fix: Image Format Compatibility and Dynamic Validation Year (Branch: enhancement/custom-format-download)
Description: The second fix addresses an issue where students faced difficulties applying for the GitHub student package due to image format incompatibility. It also introduces a dynamic validation year on the ID card.
Changes made:
-
Image Format Compatibility: Previously, the page only generated images in ".png" format, which GitHub does not accept. I have modified the code to allow users to download images in their desired format or a default format of ".jpg", solving this compatibility issue.
-
Dynamic Validation Year: The validation year on the ID card is now dynamic and not fixed. Since the program runs for a duration of a year, all intakes from coming years will automatically have the expiration date set to the next year on their ID cards but they must enter their ID as is on their portal - ALT/SCH/YEAR/ID.
-
Pull Request: Link to the second pull request
Expected behavior:
- Students should be able to download images in various formats (.jpg, .png, .jpeg, .webp) based on their preference.
- The validation year on the ID card should reflect the next year automatically.
See screenshot below:
- Students can now download pictures in formats based on their preferences.
I kindly request the project maintainers and the community to review these changes and provide feedback and suggestions. Your input will be greatly appreciated in improving the user experience and resolving the image format compatibility issue.
Thank you for your attention and support!