titoBouzout/solid-windowed

When using HTML5 (`<!DOCTYPE html>`), solid-windowed requires that html/body have height set to 100%

floer32 opened this issue · 1 comments

floer32 commented

Thanks for sharing your library. I think it fits my current project well.

It seems like Windowed requires this styling, when it's used in an HTML5 document:

html, body {
    height: 100%;
}

I realized that this issue may not be apparent in Solid Playground, because there are base styles there, including html, body { height: 100% }.

What happens without it? Well, it can be a blank page. What surprised me at first is that there were no elements being rendered by the <For> loop inside <Windowed>, in my local code... until I removed <!DOCTYPE html> from my index.html! I think it's because solid-windowed's calculations were deciding to render zero elements.

Thinking about a solution: maybe just adding a note to the README with that chunk of CSS?

floer32 commented

@titoBouzout Thanks for adding the note in the README! 👍

  • 👍1