This module is not AOT compliant

Question

This module is not AOT compliant

paynoattn opened this issue 7 years ago · 7 comments

Hello,

Thank you for developing this module! I love localforage and I love angular2.

I was getting an error when trying to build my app using AOT:
Uncaught Error: Unexpected value 'undefined' imported by the module 'LocalForageModule'

I believe these are caused by the export * from in the barrel files. See here for why.

I've managed to fix this, will be pushing a pull request soon.

Answer 1 · 2017-09-14T17:39:42.000Z

I've also noticed that the linter fails during development, specifically in the LocalForageService using the let keyword and then never reassigning the variable.

Additionally, there are several violations I've noticed in the angular styleguide.

I'll be submitting a pull request shortly.

Answer 2 · 2017-09-15T17:53:17.000Z

@radyz @Xepe Is this repository dead? I can make my own npm package and maintain it if it is.

Answer 3 · 2017-09-15T18:23:18.000Z

Hello @paynoattn,
Thanks for report the issue.

No it is not dead, I will try to review the issue this night.

Thanks.

Answer 4 · 2017-09-15T18:31:35.000Z

Awesome, there is already a PR #8.

Answer 5 · 2017-09-20T18:46:57.000Z

@Xepe any progress?

Answer 6 · 2017-11-02T21:49:11.000Z

Looks like my PR was merged, are we going to merge to master and deploy?

Answer 7 · 2017-11-09T23:09:45.000Z

Hello @paynoattn,

It is in master with version 0.1.35

Thanks for all.
Regards.