tj-actions/eslint-changed-files

[BUG] `skip_annotations: true` still posts annotations

rtizzy opened this issue · 3 comments

rtizzy commented

Is there an existing issue for this?

  • I have searched the existing issues

Does this issue exist in the latest version?

  • I'm using the latest release

Describe the bug?

When setting skip_annotations to true, annotations are still posted into the PR

To Reproduce

Try the following config for this action

      - name: ESLint changed files with Reviewdog
        uses: tj-actions/eslint-changed-files@v21
        with:
          reporter: github-pr-review
          skip_annotations: true
          filter_mode: file
          config_path: ".eslintrc.json"
          ignore_path: ".eslintignore"
          extra_args: "--rulesdir eslint-rules"
          fail_on_error: true

Create a file that fails linting

let not_a_number: string = 12
let not_a_string: number = "sup"

Create a PR and annotations are posted.

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-22.04

Expected behavior?

eslint runs and otherwise fails if relevant but does not post any annotations.

Relevant log output

N/A

Has all relevant logs been included?

  • I've included all relevant logs

Anything else?

image

Code of Conduct

  • I agree to follow this project's Code of Conduct

Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience.

Hi @rtizzy can you enable debug mode and include the relevant log output

Closing this issue as there has been no response and I’m unable to reproduce it