[BUG] - Warning: Unexpected input(s) 'extensions',
janzzen-tp opened this issue · 2 comments
Is there an existing issue for this?
- I have searched the existing issues
Does this issue exist in the latest version?
- I'm using the latest release
Describe the bug?
To eslint-changed-files
maintainers,
First off, i would like to extend gratitude to the maintainers for creating this amazing workflow to automate the linting process.
This workflow has become a great help to our team to ensure code readability and code quality.
However, we found that there were some breaking changes from @v10 so we updated the package to @v11
after updating the latest v11, we have started to receive a warning that is blocking the github actions in the workflow
please see the following snippet:
14s
##[debug]Evaluating condition for step: 'Run ESLint on changed files'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Run ESLint on changed files
##[debug]Register post job cleanup for action: tj-actions/eslint-changed-files@v[1](https://github.com/fible/fible-app/runs/6603050516?check_suite_focus=true#step:6:1)1
##[debug]Loading inputs
##[debug]Evaluating: github.token
##[debug]Evaluating Index:
##[debug]..Evaluating github:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'token'
##[debug]=> '***'
##[debug]Result: '***'
Warning: Unexpected input(s) 'extensions', valid inputs are ['token', 'all_files', 'config_path', 'ignore_path', 'file_extensions', 'extra_args', 'skip_annotations', 'level', 'reporter', 'filter_mode', 'fail_on_error']
##[debug]Loading env
Run tj-actions/eslint-changed-files@v[11](https://github.com/fible/fible-app/runs/6603050516?check_suite_focus=true#step:6:11)
with:
config_path: .eslintrc.json
extensions: js,jsx
extra_args: --quiet
token: ***
all_files: false
file_extensions: **/*.ts
**/*.tsx
**/*.js
**/*.jsx
With that said, would there be something missing the configuration that's causing this issue? Thanks for accommodating me.
To Reproduce
This is how the github action is written
name: Run Linter
on:
pull_request:
branches:
- '**'
jobs:
run-linters:
name: ESLint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12.x
- name: Install Packages
run: yarn install
- name: Run Jest
run: yarn test
- name: Run ESLint on changed files
uses: tj-actions/eslint-changed-files@v11
with:
config_path: ".eslintrc.json"
extensions: "js,jsx"
extra_args: "--quiet"
What OS are you seeing the problem on?
all
Expected behavior?
We are expecting the linter to run without warnings.
Relevant log output
14s
##[debug]Evaluating condition for step: 'Run ESLint on changed files'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Run ESLint on changed files
##[debug]Register post job cleanup for action: tj-actions/eslint-changed-files@v[1](https://github.com/fible/fible-app/runs/6603050516?check_suite_focus=true#step:6:1)1
##[debug]Loading inputs
##[debug]Evaluating: github.token
##[debug]Evaluating Index:
##[debug]..Evaluating github:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'token'
##[debug]=> '***'
##[debug]Result: '***'
Warning: Unexpected input(s) 'extensions', valid inputs are ['token', 'all_files', 'config_path', 'ignore_path', 'file_extensions', 'extra_args', 'skip_annotations', 'level', 'reporter', 'filter_mode', 'fail_on_error']
##[debug]Loading env
Run tj-actions/eslint-changed-files@v[11](https://github.com/fible/fible-app/runs/6603050516?check_suite_focus=true#step:6:11)
with:
config_path: .eslintrc.json
extensions: js,jsx
extra_args: --quiet
token: ***
all_files: false
file_extensions: **/*.ts
**/*.tsx
**/*.js
**/*.jsx
Anything else?
No response
Code of Conduct
- I agree to follow this project's Code of Conduct
Thanks for reporting this issue, don't forget to star this project to help us reach a wider audience.
@janzzen-tp I’ve added a Migration Guide to help you resolve the warning. Let me know if you need more information but a high-level description of the warning is the extension
input is no longer supported and has now been renamed to file_extensions
.