[BUG] Action doesn't fail when exit code = 1
WesleyYue opened this issue · 0 comments
WesleyYue commented
Is there an existing issue for this?
- I have searched the existing issues
Does this issue exist in the latest version?
- I'm using the latest release
Describe the bug?
- The only arg I am passing to the action is
extra_args: "--max-warnings=0"
- I get
ESLint found too many warnings (maximum: 0).
in the logs and the action proceeds to pass - I checked that eslint does indeed report exit code = 1, when running with --max-warnings=0 and the listed changed files in the github action log
To Reproduce
See bug description.
What OS are you seeing the problem on?
macos-latest or macos-10.15
Expected behavior?
Action to fail on non-zero exit codes from eslint
Relevant log output
Run # Run eslint on changed files
# Run eslint on changed files
bash $GITHUB_ACTION_PATH/entrypoint.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
CI: false
GITHUB_SERVER_URL: https://github.com
GITHUB_REPOSITORY: <redacted>
GITHUB_BASE_REF: develop
GITHUB_HEAD_REF: <redacted>
GITHUB_SHA: <redacted>
INPUT_TOKEN: ***
INPUT_PATH: .
INPUT_LEVEL: error
INPUT_ALL_FILES: false
INPUT_CONFIG_PATH:
INPUT_IGNORE_PATH:
INPUT_CHANGED_FILES: src/App.tsx src/reportWebVitals.ts src/setupTests.ts tests/dragAndDrop.ts tests/global-setup.ts
INPUT_EXTRA_ARGS: --max-warnings=0
INPUT_FILTER_MODE: added
INPUT_FAIL_ON_ERROR: true
INPUT_REPORTER: github-pr-review
INPUT_SKIP_ANNOTATIONS: false
eslint-changed-files
Resolving repository path: <redacted>.
Running ESlint on changed files...
ESLint found too many warnings (maximum: 0).
Anything else?
No response
Code of Conduct
- I agree to follow this project's Code of Conduct