tj64/outshine

newcomment required

Closed this issue · 2 comments

Outshine uses functions like 'comment-add' which are not autoloaded in newcomment.el, so outshine.el needs to have (require 'newcomment) somewhere.

By the way, Thanks for your work, it's a game changing for productivity. I wanted such a tool and was thinking of implementing one myself, but now I can do real work :)

tj64 commented

Thank you for giving these libraries a try, its very valuable to get some feedback about what happens when they are used on another machine with other settings. And its encouraging not to be the only one who feels the productivity gain.

Actually, outshine doesn't use functions but rather variables from newcomment.el:
comment-add
comment-end
comment-padding (option)
comment-start

Do you get an error in this case? Isn't newcomment.el loaded by default - I do nothing special to load it, and the mentioned variables are always defined here with my Emacs settings.

Its no problem to require newcomment.el, and I do it for now, but maybe you can give me a bit more info? Would it be enough to declare these variables in outshine, since newcomment.el is loaded anyway?

tj64 commented

Ok, I investigated a bit, and it is indeed necessary to require 'newcomment' for Emacs versions older than 24.3. Thanks for the tip!