Better detection for platform OS
mhartington opened this issue · 2 comments
mhartington commented
Since lua LSP has predictable platforms it builds to, you could do a conditional check and set the bin location
nlua.nvim/lua/nlua/lsp/nvim.lua
Line 7 in b24d838
if jit.os == 'osx' then
local bin_location = 'macOS'
elseif jit.os == 'linux' then --or what ever the value returned by linux
local bin_location = 'Linux'
....
Just some ideas
martini97 commented
This is what I did to fix the command on Mac: https://gitlab.com/martini97/dot-nvim/-/commit/b6f627ce8ac9c2eeb303237afe3abbf8d9de4a20
wantyapps commented
This is what I do in my pr! Please note that the macOS jit.os value is in uppercase. Not "osx", but "OSX".