Typo: type_of_gpx_fix should be type_of_gps_fix ?
gregoryng opened this issue · 1 comments
Minor typo shows up in a few places in gpx.py. There is a field called "type_of_gpx_fix", but I think it should be called "type_of_gps_fix." I assume it is referring to "type of gps fix", which the topografix manual has also made this error in one spot, but generally refers to this as "GPS fix".
I guess it is consistent in the code to internally call it "type_of_gpx_fix" rather than "type_of_gps_fix", but technically it doesn't quite make sense.
I see 8 occurrences in gpx.py
but this is the first:
Line 66 in 4b90ead
It also shows up in test.py
.
Don't know if the right response is to allow either field or to deprecate type_of_gpx_fix.
Yes, you're right. Thanks for pointing this out.
I'm also not sure how to fix it, but I'll think of something.