Always use Forward Slash "/" for package paths
sampaioletti opened this issue · 2 comments
sampaioletti commented
From tscriptify/main.go:78
packageParts := strings.Split(packagePath, string(os.PathSeparator))
packages in go always use forward slash even on windows
https://stackoverflow.com/questions/45323772/invalid-import-path-go-windows
should be
packageParts := strings.Split(packagePath, "/")
sampaioletti commented
Yeah no worries, great library. Using it to get some type safety on our json-rpc calls. Working like a champ. Thanks!
From: Tomo Krajina <notifications@github.com>
Sent: Thursday, August 16, 2018 9:37 AM
To: tkrajina/typescriptify-golang-structs <typescriptify-golang-structs@noreply.github.com>
Cc: sampaioletti <sampaioletti@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [tkrajina/typescriptify-golang-structs] Always use Forward Slash "/" for package paths (#10)
Yes, you're right, silly mistake on my part.
Fixed now ( <9191385> 9191385). Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#10 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AIZod8dnG5qMqbDcqUa6EyevSVLTUtDeks5uRZGfgaJpZM4V-gNy> .