allow user to share HTTP onion url for their onionservice
Closed this issue · 3 comments
n8fr8 commented
- copy and paste
- sharesheet?
- QR code?
tladesignz commented
Copy/paste:
QR Code:
Sharesheet
Nice idea!
However, before I implement that, can we talk about a URL format which includes both the address and the key?
I suggest two options:
- Use "password" piece of URL:
http://:somerandomkey@example.onion/
-
Cons:
- Looks strange to most users.
- Unsure if messenger clients destroy that.
-
Pro:
- Actually exactly where it belongs.
- Perfectly valid.
- Doesn't end up in server logs.
- Use a "key" query:
http://example.onion/?key=somerandomkey
-
Cons:
- Arbitrary, non-standard "key" value.
- Might end up in server logs.
-
Pros:
- Looks more familiar to users.
- Highly unlikely that it gets mangled by any client.
tladesignz commented
Let's discuss there: onionshare/onionshare-shared#2
tladesignz commented
I replaced the clipboard and QR code buttons with a share sheet, which is way more iOS-sy. That supports copy-to-clipboard and QR code display just as well and doesn't take up so much screen estate.
So, all done here, but let's discuss the URL format over at onionshare-share further!