unused parameter 'order' in sigdecode_der(sig_der, order)
opacey opened this issue · 3 comments
opacey commented
The 'order' parameter is not used in this function:
def sigdecode_der(sig_der, order):
...within ecdsa/util.py
I believe curve group order is not relevant to this function so could be removed for clarity.
tomato42 commented
it's part of the API that the function must follow to be usable for signature verification, it needs to stay
opacey commented
Oh I see, fair enough, though it did cause me (a newcomer) some confusion in figuring out other issues I was having. Perhaps its status could be noted in the documentation to help those like me. Thanks.
tomato42 commented
PR with doc updates welcome, but I think the module description for util.py makes it rather clear:
python-ecdsa/src/ecdsa/util.py
Lines 2 to 11 in 2457dc7