tmcw/notfoundbot

What should the behavior be if there's an existing PR around?

tmcw opened this issue · 1 comments

tmcw commented

Right now, this action bails if it's already opened a PR yesterday and it's running today. Is that the right behavior? Instead, maybe it should add commits to the existing PR?

I wonder what the ideal is here for people's workflows: lots of small PRs are annoying and a few big PRs are hard to review, ideally we land somewhere in the middle.

I think bailing out if an existing PR is already open is good. If they're not being merged, then what's the point anyway.

Dependabot does something similar, though it has a configuration option to open at-most N PRs. I think that's more complexity than is necessary for notfoundbot.

Maybe a middleground is that it could leave a comment on the open PR along the lines of:

Notfoundbot tried to run on [DATETIME] but exited because this PR is still open. Please merge or close this PR to allow dependabot to continue updating links.