Wrong passwords when name contains non-ascii characters
jeffrson opened this issue · 6 comments
When the user name contains umlauts (for example) the generated password is apparently wrong.
Example:
Full name: Jens Weißmüller
Master Password: 123
Site: eBay
Counter: 1
Template: Medium
Generated: Yar8/Fos
Correct: JidHeh8_
I believe I have isolated the bug. I believe it is occuring at mpw.js#L50 where the length of the binary string is added and not the number of characters in the string which appears to be inconsistent with MasterKey.java. I'll work on fixing this later.
Can @lhunath confirm that this is the intended case?
What you want is to use the length in bytes, not the number of "characters". It looks like MasterKey is broken, too.
The behaviour of mpw-js is consistent with what @lhunath has said so I'm marking this as wontfix. I will leave it open though until a fix reaches the official app. Until that point it's still an inconsistency.
note: unless we can figure out how to compile scrypt-asm ourselves reliably, https://js.masterpasswordapp.com will likely move to cuardin's implementation.
I've closed this issue as 'Desktop (Java)' now also reflects the correct behaviour.