Standardize support for Names vs Numbers for Levels
martindsouza opened this issue · 3 comments
martindsouza commented
Some of the code takes in numbers and other parts take in names for level references. Overload all code like this so one standard is across the board and have a common option for all code on a go forward basis so it's consistent.
martindsouza commented
Done
martindsouza commented
It turns out that when overloading set_level will cause some issues.
procedure set_level(
p_level in varchar2 default logger.g_debug_name,
p_client_id in varchar2 default null,
p_include_call_stack in varchar2 default null,
p_client_id_expire_hours in number default null
);
procedure set_level(
p_level in number,
p_client_id in varchar2 default null,
p_include_call_stack in varchar2 default null,
p_client_id_expire_hours in number default null
);
Then calling:
begin
logger.set_level(
p_level => 2,
p_client_id => 2
);
end;
/
ORA-06550: line 2, column 3:
PLS-00307: too many declarations of 'SET_LEVEL' match this call
To get around this issue will only have one instead of set_level
and check to see if p_level
is a number.
martindsouza commented
This issue was moved to OraOpenSource#48