tmux-plugins/vim-tmux

Requesting ability to configure the Shift+K bind override

unphased opened this issue · 14 comments

I have an action bound to K in Vim (Move down 7 lines), and I use it a lot.

I also really like the vim-tmux syntax highlighting for my tmux config. However I have not come up with a nice way to remove the binding because it will be reinstated every time that vim-tmux updates itself via tpm.

Any ideas? Is there a way to use ~/.vim/after/vim-tmux.vim or something? I tried it but it didn't work for some reason.

I can obviously fork and change but then I would have to manually update this plugin.

Should now be fixed with this commit e9b0d6b.
The plugin won't override your mapping. Please let me know if you still have trouble.

Sweetness. Thanks!

(Finally) tested, and it works!

@bruno- I think this doesn't work anymore? It's a regression?

Hi,

I made no changes to this since this plugin was originally developed.

But it seems like this 9ead258 did?

Man .. that was half a year ago and I would swear I didn't commit that. LOL
Do you know what might be a problem with that one?

Yes.

The maparg produces for me {'silent': 0, 'noremap': 1, 'lhs': 'K', 'mode': ' ', 'nowait': 0, 'expr': 0, 'sid': 1, 'rhs': '5gk', 'buffer': 0} and so the logic in 9ead258 seems to say "if K is not bound OR if it is not bound in this buffer, assign K". The second condition holds true, so K becomes overridden for me.

Hmm.. it seems we just need to change the OR condition to AND, right?

Yeah that makes more sense to me... I’ll do the change and give you a pull request!

Hey, the PR #20 caused issue #21 that was easily reproducible. I reverted #20 for now.

I tested this again and I think we could revert 9ead258 and everything should work fine.

Interesting! Changing how it short circuits broke older vims? Or something??

Confused because 9ead258 was what introduced the check for the buffer field...

Ok let’s revert 9ead258 then, as you say. I’ll let you do it.

Sorry for breaking stuff

Ok reverted.