tnich/honssh

HonSSH feature request:input validation or verbose error messages to stdout

Closed this issue · 5 comments

What steps will reproduce the problem?

1.
Enter an invalid in into honssh.cfg, "ssh_addr = 0.0.0."


2.
Execute honsshctrl.sh.

# ./honsshctrl.sh START
Starting honssh in background...
2014-05-04 16:01:35+0200 [-] Log opened.
2014-05-04 16:01:35+0200 [-] Starting factory 
<honssh.client.HonsshSlimClientFactory instance at 0x2f75ef0>
2014-05-04 16:01:35+0200 [-] Loaded.
2014-05-04 16:01:35+0200 [-] Log opened.
2014-05-04 16:01:35+0200 [-] twistd 11.1.0 (/usr/bin/python 2.7.3) starting up.
2014-05-04 16:01:35+0200 [-] reactor class: 
twisted.internet.pollreactor.PollReactor.
#

HonSSH appears to start and creates the honssh.pid file, but (for obvious 
reasons) you will not be able to stop it.

# ./honsshctrl.sh STOP
Attempting to stop HonSSH (1355)...
ERROR: Unable to stop HonSSH (1355)
#


3.
Checking the honssh.log i see this.

- Log error form malformed IP address "0.0.0.".
2014-05-04 16:01:36+0200 [-] twisted.internet.error.CannotListenError: Couldn't 
listen on 0.0.0.:22: [Errno -2] Name or service not known.

- Log error from an invalid port number "222222"
2014-05-04 16:04:41+0200 [-] OverflowError: getsockaddrarg: port must be 
0-65535.


What is the expected output?
Its easy enough to find the cause of the issue in the honssh.log,
but it would be nice to have these lines sent to stdout as well.

What version of the product are you using?
b13ef1d01b16

On what operating system?
Ubuntu server 12.04 LTS


Please provide any additional information below.
Havent used HonSSH for a while.
Awesome to see what you've accomplished over the last weeks :D


//Are

Original issue reported on code.google.com by are.hans...@gmail.com on 4 May 2014 at 2:13

I guess I should implement this :P

ETA 11/5/14

Original comment by tnn...@googlemail.com on 5 May 2014 at 11:59

  • Changed state: Accepted
Not a big deal really, but it would be convenient :)

Sent from my Nokia 3310.

Original comment by are.hans...@gmail.com on 5 May 2014 at 3:37

I'm fixing a small issue in honsshctrl.sh with the keys. If you like I could 
prolly get the last entries from honssh.log as a temporary work around for this?

Sent from my Nokia 3310.

Original comment by are.hans...@gmail.com on 8 May 2014 at 10:49

It's alright, it will be better placed in the HonSSH code. Thanks for the offer 
though :D

Original comment by tnn...@googlemail.com on 9 May 2014 at 6:31

This issue was closed by revision 8b3de40b87d8.

Original comment by tnn...@googlemail.com on 18 May 2014 at 11:04

  • Changed state: Fixed