todc/todc-bootstrap

select2 distribution

acmetech opened this issue · 8 comments

acmetech commented

@todc, would you like select2 to be distributed with todc-bootstrap or would you like it to be a separate download for the user?

todc commented

I could probably be persuaded either way. I think I'm leaning towards keeping it separate. What do you think?

acmetech commented

I think it would be nice to not maintain a separate fork of select2. It would be nice to either offer a todc-bootstrap theme or include the select2 customizations directly in todc-bootstrap. This way we could make use of all the variables/mixins to customize the look of select2.

thezoggy commented

why not just use a submodule? link to the git repo
http://git-scm.com/book/en/Git-Tools-Submodules

acmetech commented

@todc, any additional thoughts?

todc commented

Yeah, submodules is certainly another way to go.

I don't think we should bundle select2 as part of our BS3 distribution. Including it in the docs is a different story. I think that's fine as long as we make it clear that it's a 3rd party module that isn't inherently part of BS3.

acmetech commented

I will make sure the callout reflects this.

Do you have an ETA on BS3 support for select2? I would like to get a pull request together when BS 3.0.1 drops. I can always remove select2 from the docs if select2 support isn't ready. todc/todc-select2#11

Thanks

todc commented

I'll knock it out sometime this week. Have had a lot on my plate lately; sorry for the delays.

acmetech commented

Thanks. I understand, no problem.