toddmotto/fluidvids

Return FluidVids from closure

at0g opened this issue · 2 comments

at0g commented

The script won't work with dynamic content as the closure does not return anything.

eg. window.fluidvids === null // true

The closure function should return Fluidvids.

I'm actually looking at re-writing FluidVids using a Module Pattern to do exactly this :) if you've any ideas feel free to share on patterns.

at0g commented

Have sent you a pull request, implementing this approach:
https://github.com/umdjs/umd/blob/master/amdWeb.js