tohojo/flent

Found fping, but it outputs broken timestamps

dunxd opened this issue · 3 comments

dunxd commented

I get the following error when running the following command:

% flent rrul -p all_scaled -l 60 -H netperf.bufferbloat.net -o test-flent.png
Starting Flent 2.0.1 using Python 3.9.6.
Starting rrul test. Expected run time: 70 seconds.
WARNING: Found fping, but it outputs broken timestamps (off by 1628602397.488081s). Not using.
ERROR: Runner Ping (ms) ICMP failed check: Cannot parse output of the system ping binary (/sbin/ping). Please install fping v3.5+.

I have fping 5 installed. I'm not sure if this is an issue with my Mac or with the install. How would I tell.

I am running macOS Big Sur 11.5.1 and installed flent using home-brew according to the documentation.

tohojo commented

You'll need to downgrade your version of fping, or patch it. See schweikert/fping#203

randomizedcoder commented

schweikert/fping#203 suggests this is fixed in fping 5.1, but flent is still not happy.

das@3rd:~/Downloads/cake/cmd/run_qdiscs_tests$ /usr/bin/sudo /usr/sbin/ip netns exec network101 /usr/bin/flent rrul --output  /tmp/qdisc/2023-10-13T15:53:21/pi4/noqueue/flent/test/15_flent/flent_pi4_noqueue.png --data-dir /tmp/qdisc/2023-10-13T15:53:21/pi4/noqueue/flent/test/15_flent/ --format summary --plot all_scaled --title-extra 2023-10-13T15:53:21_pi4_noqueue --note 2023-10-13T15:53:21_pi4_noqueue --extended-metadata --host 172.17.51.10 --length 60 --ipv4 --socket-stats
Starting Flent 2.0.1 using Python 3.10.12.
Starting rrul test. Expected run time: 70 seconds.
WARNING: Found fping, but couldn't parse its output. Not using.              <---------------- ???
ERROR: Runner Ping (ms) ICMP failed check: Cannot parse output of the system ping binary (/usr/bin/ping). Please install fping v3.5+.    <----- ??

das@3rd:~/Downloads/cake/cmd/run_qdiscs_tests$ dpkg --list | grep ping
ii  fping                                 5.1-1                                   amd64        sends ICMP ECHO_REQUEST packets to network hosts
ii  iputils-ping                          3:20211215-1                            amd64        Tools to test the reachability of network hosts
ii  kpartx                                0.8.8-1ubuntu1.22.04.1                  amd64        create device mappings for partitions
ii  libharfbuzz0b:amd64                   2.7.4-1ubuntu3.1                        amd64        OpenType text shaping engine (shared library)
das@3rd:~/Downloads/cake/cmd/run_qdiscs_tests$ fping --version
fping: Version 5.1
das@3rd:~/Downloads/cake/cmd/run_qdiscs_tests$ ping -V
ping from iputils 20211215

das@3rd:~/Downloads/cake/cmd/run_qdiscs_tests$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=22.04
DISTRIB_CODENAME=jammy
DISTRIB_DESCRIPTION="Ubuntu 22.04.3 LTS"

I did install via "apt install fping flent"

Looking at the code here

flent/flent/runners.py

Line 1343 in 7b93191

out, err = self.run_simple([fping, '-D', '-c', '1',

We can see the fping it's doing.

das@3rd:~/Downloads/fping$ fping -D -c 1 -r 0 -t 200 localhost 1.1.1.1
[1697218661.57475] localhost : [0], 64 bytes, 0.020 ms (0.020 avg, 0% loss)
[1697218661.59916] 1.1.1.1   : [0], 64 bytes, 14.2 ms (14.2 avg, 0% loss)

localhost : xmt/rcv/%loss = 1/1/0%, min/avg/max = 0.020/0.020/0.020
1.1.1.1   : xmt/rcv/%loss = 1/1/0%, min/avg/max = 14.2/14.2/14.2
das@3rd:~/Downloads/fping$ fping -D -c 1 -r 0 -t 200 localhost one.one.one.one
[1697219019.58640] localhost       : [0], 64 bytes, 0.015 ms (0.015 avg, 0% loss)
[1697219019.60944] one.one.one.one : [0], 64 bytes, 12.9 ms (12.9 avg, 0% loss)

localhost       : xmt/rcv/%loss = 1/1/0%, min/avg/max = 0.015/0.015/0.015
one.one.one.one : xmt/rcv/%loss = 1/1/0%, min/avg/max = 12.9/12.9/12.9
tohojo commented