toji/gl-matrix

quat.fromEuler uses degrees

magcius opened this issue · 2 comments

magcius commented

As far as I can tell, this is the only API that seems to use degrees, which is bizarre. Everywhere else uses radians. It's documented, but it was a bit of a footgun for me.

stefnotch commented

That is true, depending on how much attention this issue gets, we might want to change that.

For the record, there are other APIs that use degrees for euler angles and radians for pretty much everything else, like Unity's API

There is one other API that uses degrees, because it's explicitly designed for WebVR

toji commented

Worth noting that the WebVR is deprecated now and WebXR (it's replacement) no longer reports FOVs directly, so perspectiveFromFieldOfView's use cases are likely quite limited now.

  • 👍1