toji/gl-matrix

IndexedCollection type not available in releases

Closed this issue · 4 comments

davazp commented

I noticed the change from Float32Array in the types to IndexedCollection and I needed to use this for my current project.

I am using the latest release on npm 3.4.3, but there the type is still Float32Array:
https://www.npmjs.com/package/gl-matrix?activeTab=code

I am bit confused with the state of the branches/tags/releases. There is no git tag for 3.4.3, so I don't know from what git commit it was released. There is a git branch 3.4.x that still uses Float32Array, but there is a tag for 3.4.1 which does contain IndexedCollection, but was not released to npm.

https://github.com/toji/gl-matrix/blob/v3.4.1/src/types.d.ts

So my questions are, where was 3.4.3 released from? and would be it possible to get a released with the IndexedCollection changes included?

In the meantime, I have a patch applied to adjust the types locally, so it is not a big deal if this cannot happen for backward compatibility or other reasons.

Thanks!

mourner commented

We've run into this too when migrating Mapbox GL JS to TypeScript. @toji it would be really nice to get v3.4.4 with the updated types 🙏

  • 👍1
stepankuzmin commented

Hi @toji,

Just wanted to check if there’s a chance to get a patch release (v3.4.4) with the updated TypeScript typings. It would save developers from maintaining local patches 🙏

stepankuzmin commented

Hi @toji,

I'm flagging this again for visibility. It would be really helpful to get a v3 patch release with the updated TypeScript typings 🙏

mourner commented

Looks like this change got into v3.4.4 (thank you!) so this issue can be closed.

  • ❤️2