Upgrade to new tokio?
izderadicka opened this issue · 7 comments
Hi,
what are plans for upgrade to new tokio?
I'm especially interested because I used it with hyper 0.11 for server side tls (via tokio-proto), but with new hyper 0.12 this option is not available.
I would accept a PR that makes the change.
I'm not sure I know enough of tokio to be able to do the change.
Especially not sure about tokio-proto as it's looks deprecated - what to use instead of it?
Ah, all the tokio-proto stuff can probably just be deleted.
@carllerche - with tokio-proto deleted it was not so difficult even for a beginner (although I made some changes rather mechanically). Tests are running and also examples apart of hyper-server (on linux), which I'll try later. I might disappear for few days, so if you'd like to review with that hyper example, let me know I can submit PR. I also included changes from PR#43 to be able to use latest native-tls 0.2.
Hey, I fixed the hyper-server example. It was crashing when the connection fails. This was happening due to clients not trusting the self signed certificate. Now it seems to work fine, though it could probably be written nicer. I could not find a nice way to recover from the error.
Since there was no PR I opened one.
@carllerche would you be able to accept PR #45? Or what needs to be done to move ahead?
Closing as #45 is accepted