tom-englert/Wax

ComponentGroupRef are not inserted in any feature

Closed this issue · 6 comments

Leogiciel commented

Documentation says :
Wax will add a ComponentGroupRef node for all component groups it creates to the first feature it finds in your project. If you have just one feature defined, this will be fine; if you have more than one feature in your setup project, copy or move the entries as desired.

  <Product ...>
    <Feature Id="ProductFeature" Title="ACME.Setup" Level="1">
      <ComponentGroupRef Id="ProductComponents" />
      <ComponentGroupRef Id="de_files" />
      <ComponentGroupRef Id="fr_files" />
    </Feature>
  </Product>

But no componentGroupRef is generated in my Wix project.

tom-englert commented

It works fine for me - can you debug this to see what happens? Add a break point at the method ForceFeatureRef()

Leogiciel commented

The method adds effectively a componentgroupref to first found feature object, but nothing changes in the .wxs file...

Leogiciel commented

I'm trying to understand and fix this...

Leogiciel commented

Freshly created "bin_files" ComponentGroup is not found in my whole project as a ComponentGroupRef :

capture2

My only feature :
capture3

tom-englert commented

Maybe just the "Save" was missing? I think you added this in your last PR, right?

Leogiciel commented

Exactly, SourceFile.Save did the trick.

Fixed by commit fe5275b #30