crash during github sso due to email missing
ichernev opened this issue · 0 comments
ichernev commented
This line causes a crash sometimes: https://github.com/tomasvotava/fastapi-sso/blob/master/fastapi_sso/sso/github.py#L23C20-L23C37
It is more likely to happen if you do SSO with github with the same person multiple times in short succession (i.e more than 5 one after the other). The email seems to be missing (not sure about other fields). Ideally the code should use .get()
instead of []
.
I might post more data if I manage to capture the body.