tombatossals/angular-openlayers-directive

Https protocol option for Esri layer

Closed this issue · 3 comments

mfilotto commented

Would be nice to be able to activate https on Esri layers.

My use case:
My app is in https so when I display an Esri layer I have these errors
Mixed Content: The page at 'https://myapp.ovh/#/map' was loaded over HTTPS, but requested an insecure image 'http://services.arcgisonline.com/ArcGIS/rest/services/World_Imagery/MapServer/tile/11/1153/1967'. This content should also be served over HTTPS.

juristr commented

@mfilotto Hey, definitely. Would you like to submit a pull request? The code line to change would be this one:

angular-openlayers-directive/src/services/olHelpers.js

Line 393 in 33008fe

var _urlBase = 'http://services.arcgisonline.com/ArcGIS/rest/services/';

mfilotto commented

Of course.
Do you want me to hard code https url or add an option to switch between http and hhtps ?

juristr commented

I think we can hard-code it. Calling an https resource from an http site doesn't hurt, vice versa however you get the error you got 😄 . so I think we're fine hard-coding it for now. In case we can add configuration options later if needed.

thx 👍