[request] missing option :leak-detection-threshold

Question

timgluz opened this issue 9 years ago · 6 comments

Hi,

i'm currently trying to find a connection leak in my app and i noticed i cant change leakDetectionThreshold value.

Answer 1 · 2015-12-03T14:53:56.000Z

Would it work for you to set it using the configure option? It would probably something along the lines of:

(make-datasource {:configure (fn [cfg] (.setLeakDetectionThreshold ...))})

Answer 2 · 2015-12-03T14:55:39.000Z

i'll give a try - but i already forked a project to add a new optional-key into settings map.

Answer 3 · 2015-12-03T14:57:53.000Z

In such case a PR is more than welcome! I'd be excellent if your patch also updates the list of options in README and adds a changelog entry.

Answer 4 · 2015-12-03T15:44:37.000Z

@jstepien Btw, do you use hikari-cp in production? Have you ever encountered connection-leak with it?

Answer 5 · 2015-12-03T15:47:19.000Z

We do, with both MySQL and PostgreSQL, and to the best of my knowledge we haven't experienced problems you described in brettwooldridge/HikariCP#513

Answer 6 · 2015-12-03T16:49:57.000Z

Merged in #19