tomekw/hikari-cp

Fix Readme :jdbc-url should be :url

ivos opened this issue · 7 comments

ivos commented

Got confused when trying to use :jdbc-url config param. Then I found out in the H2 example below that it should actually be :url.

Thanks @ivos ! Please find the referenced PR.

Ah, so it's other way around?

ivos commented

Yea, using H2 and :jdbc-url didn't work. After switching to :url it started to work.

A bit confusing for me, because the source indicate you work with :jdbc-url...

ivos commented

A working example: ivos/clojure-jdbc-sample@c45b002

In src/clojure_jdbc_sample/core.clj, lines 14 and 15.

Line 15 works. Line 14 says "No suitable driver found for ". Which indicates that the URL is actually an empty String.

I've just tried it and I can confirm it; h2 works with :url but fails with :jdbc-url, just as reported by @ivos. The h2 example appears to be correct as of current master, 139704e. What we might need is a footnote in the Configuration options table saying that h2 expects :url.

@tomekw should we close #28?

@jstepien done! :)

Thanks a lot! :)