ability to supply the datasource directly
Closed this issue · 3 comments
yogthos commented
It would be nice to have an option to pass in a configured datasource or to provide a custom classname. I'm using hikari-cp in my conman library for Luminus. Currently, it's setup to accept :datasource and :datasource-classname keys. The datasource can be used instead of the jdbc-url and the adapter. Meanwhile, the datasource classname can be used with the jdbc-url to initialize a datasource.
jstepien commented
Sounds good. We'd love to see a patch introducing this change!
yogthos commented
sounds good, I'll take a look at doing a pr this