inconsistent naming of options

Question

inconsistent naming of options

jjl opened this issue 8 years ago · 6 comments

:datasource-classname and :driver-class-name are inconsistently formatted.

Answer 1 · 2017-01-24T13:56:01.000Z

Oh, that's unfortunate :( Thank you for bringing this. @jstepien WDYT about changing this in 1.8.0? Or 2.0.0? I will be happy to unify this.

Answer 2 · 2017-01-24T14:09:38.000Z

Sure, I'd be happy to accept a patch fixing it. Not to break existing clients I'd love to have it support both : datasource-classname and : datasource-class-name and release it as 1.8.0.

Answer 3 · 2017-01-24T14:10:52.000Z

Yes, this also a way to go /cc @jjl

Answer 4 · 2017-01-24T14:39:11.000Z

I think I can probably submit a PR for that once I've got the work that caused me to notice this out of the way.

Answer 5 · 2017-01-24T14:45:27.000Z

Perfect! No rush.

Answer 6 · 2017-09-13T07:45:36.000Z

@jjl still able submit a PR? :)