tomekw/hikari-cp

MetricsRegistry is erroneously forwarded to the datasource

sebastianpoeplau opened this issue · 6 comments

When the option :metric-registry is specified in a call to datasource-config, hikari-cp attempts to set the property "metricRegistry" in the datasource instead of just setting the registry in HikariConfig, which fails at least for Postgres.

The reason, I believe, is that datasource-config fails to remove :metric-registry from the options before setting datasource properties. Will submit a PR...

gaczm commented

@tomekw @jstepien Can you release new version with this fix included?

@gaczm sure, I will do this in the evening unless @jstepien will be first :)

gaczm commented

thanks :)

@gaczm done!