How to update dotsIndicator adapter ?

Question

How to update dotsIndicator adapter ?

manishpatelgt opened this issue 5 years ago · 6 comments

I don't see any notifyDataSetChanged() method that updates items in dotsIndicator adapter ?

When i add new item in my main viewpager adapter my app get crash. See below logs

10.09.19 14:57
Version: 1.0.43 (1043tackTrace)
Thread[main,5,main]
Exception: java.lang.ArrayIndexOutOfBoundsException
Message: length=10; index=-1
Stacktrace:
	java.util.ArrayList.get(ArrayList.java:439)
	com.tbuonomo.viewpagerdotsindicator.SpringDotsIndicator$buildOnPageChangedListener$1.onPageScrolled$viewpagerdotsindicator_release(SpringDotsIndicator.kt:161)
	com.tbuonomo.viewpagerdotsindicator.OnPageChangeListenerHelper.onPageScrolled(OnPageChangeListenerHelper.kt:17)
	com.tbuonomo.viewpagerdotsindicator.BaseDotsIndicator$setViewPager$2$addOnPageChangeListener$1.onPageScrolled(BaseDotsIndicator.kt:218)
	androidx.viewpager.widget.ViewPager.dispatchOnPageScrolled(ViewPager.java:1930)
	androidx.viewpager.widget.ViewPager.onPageScrolled(ViewPager.java:1904)
	androidx.viewpager.widget.ViewPager.pageScrolled(ViewPager.java:1842)
	androidx.viewpager.widget.ViewPager.completeScroll(ViewPager.java:1988)
	androidx.viewpager.widget.ViewPager.scrollToItem(ViewPager.java:692)
	androidx.viewpager.widget.ViewPager.setCurrentItemInternal(ViewPager.java:670)
	androidx.viewpager.widget.ViewPager.setCurrentItemInternal(ViewPager.java:631)
	androidx.viewpager.widget.ViewPager.dataSetChanged(ViewPager.java:1086)
	androidx.viewpager.widget.ViewPager$PagerObserver.onChanged(ViewPager.java:3097)
	androidx.viewpager.widget.PagerAdapter.notifyDataSetChanged(PagerAdapter.java:291)

Answer 1 · 2019-09-10T11:33:28.000Z

Hi @manishpatelgt,
You have to call the notifyDataSetChanged() on your adapter (the one linked to the view pager).
The dots will be refreshed automatically.

The reason of your crash is there is no item in your adapter. I'll fix this

Answer 2 · 2019-09-10T11:39:58.000Z

@manishpatelgt Can you try again with the version 4.1.2 ?
Thanks

Answer 3 · 2019-09-10T12:54:00.000Z

@tommybuonomo Let me check with 4.1.2

Answer 4 · 2019-09-10T13:09:53.000Z

@tommybuonomo Yes it worked very well. Thanks for quick fixed

Answer 5 · 2021-07-06T06:04:12.000Z

Fatal Exception: java.lang.ArrayIndexOutOfBoundsException: length=10; index=-3 at java.util.ArrayList.get(ArrayList.java:439) at com.tbuonomo.viewpagerdotsindicator.DotsIndicator$buildOnPageChangedListener$1.onPageScrolled$viewpagerdotsindicator_release(DotsIndicator.java:107) at com.tbuonomo.viewpagerdotsindicator.OnPageChangeListenerHelper.onPageScrolled(OnPageChangeListenerHelper.java:22) at com.tbuonomo.viewpagerdotsindicator.BaseDotsIndicator$setViewPager$2$addOnPageChangeListener$1.onPageScrolled(BaseDotsIndicator.java:218)

I am still getting the same crash on 4.1.2.
What could be the fix for that? @tommybuonomo

Answer 6 · 2021-09-17T15:15:30.000Z

Fatal Exception: java.lang.ArrayIndexOutOfBoundsException: length=10; index=-3 at java.util.ArrayList.get(ArrayList.java:439) at com.tbuonomo.viewpagerdotsindicator.DotsIndicator$buildOnPageChangedListener$1.onPageScrolled$viewpagerdotsindicator_release(DotsIndicator.java:107) at com.tbuonomo.viewpagerdotsindicator.OnPageChangeListenerHelper.onPageScrolled(OnPageChangeListenerHelper.java:22) at com.tbuonomo.viewpagerdotsindicator.BaseDotsIndicator$setViewPager$2$addOnPageChangeListener$1.onPageScrolled(BaseDotsIndicator.java:218)

I am still getting the same crash on 4.1.2.
What could be the fix for that? @tommybuonomo

Hi, I have the same issue. Did you fix it ?