tomthecarrot/arcore-for-all

ARCore Preview v2

Opened this issue ยท 8 comments

vdbo commented

Hello there :)

At first I want to say thank you for providing Google's ARCore library which can be installed on other devices. Great job ๐Ÿ‘
And are you planning to make the new build with ARCore v2 preview?

Thanks in advance

@vdbo Thank you for your support! It would be great for this repo to be compatible with ARCore v2, but I have not yet had time to test it on the v2 library. Please feel free to research, collaborate, and make modifications to support v2! PRs are welcome :)

Hi!
I am interested in helping here. @tomthecarrot could you explain what exactly you did for v1?

Thanks @Torbilicious! I detailed the process in the README at the root of this repo. Happy to answer any questions about the process, just let me know! :)

Had a quick look on decompiled sources: looks like there is no plain java class for supported devices, instead Session has native method wrapped with javish isSupported -> so we have to re-compile this class with android sources linked to the process

vdbo commented

@almozavr totally right!
A support for device is checked in Session class, but it seems like it's the fundamental class.
So how do you think, is there any possibility that we can break down some functionality during decompilation?

The method we are looking for is a dead simple oneliner, but I haven't checked imports yet, so not sure if everything is linkable

How is it going?My device is s8+,and I have try it,but it doesn't work.

I followed your steps for the v1 library but when trying to recompile the changed (now called Session) class i got a whole bunch of errors.

pastebin

All the classes that it says are missing can be found (Config, Anchor, Frame, ...). Can anyone make something of those errors?