tomwhite007/rename-angular-component

Does not work in VSCODE devcontainer

Opened this issue · 2 comments

Describe the bug
Using this extension in a running devcontainer does not work

To Reproduce
Steps to reproduce the behavior:

  • use VSCODE.
  • add a devcontainer in an existing angular projet
  • use image typescript-node
  • add feature angular-cli
  • install this extention in container
  • try to rename a component with right click : nothing happens
  • try to rename with command by copying path of file : showing "Cannot find file. Stopped." notification

Expected behavior
Renaming is working or error is clearly shown in output

Screenshots or Demo Repo
If applicable, add screenshots or link to a repo to help explain your problem.

Desktop (please complete the following information):

  • OS: Ubuntu
  • devcontainer file
  "image": "mcr.microsoft.com/devcontainers/typescript-node:1-22-bookworm",
  "features": {
    "ghcr.io/devcontainers-extra/features/angular-cli:2": {}
  },

Hello @sylvainfaubet

Thank you for taking the time to write a detailed issue. My apologies for the delay in responding.

The issue you raise is the same requirement as this thread #28 (comment) .

At the time of that comment, VSCode did not have an api to access its 'Find All References' menu action programmatically from a VSCode extension. Imo, I think this is a feature in VSCode that was sorely lacking.

Now that you have prompted me, I will investigate whether Microsoft has decided to let extensions have access to it and report back here. Unfortunately, it's your only hope. The performance at scale of vscode.workspace.fs vs Node fs is ridiculously poor and therefore unusable for virtual file systems to use this extension.

I can confirm, VSCode has not yet given api to access its 'Find All References' menu action. This means I cannot make VSCode Virtual File System work because the performance is soooooo poor at scale. My apologies.