Add toncoin to trust wallet assets
PolyProgrammist opened this issue ยท 23 comments
Summary
Add information about toncoin to trust wallet assets repository https://github.com/trustwallet/assets/tree/master/blockchains
Context
Trust Wallet assets repository is used to provide information about crypto coins for a large number of applications. Adding toncoin to this repository would allow these applications to use information about toncoin such as website domain, logo, name, symbol, etc.
Goals
Merge pull request with information about toncoin into trust wallet assets repository
Deliverables
An ability to see toncoin in trust wallet assets repository
Definition of Done
[] Merged pull request with information about toncoin repository in trust wallet
Reward
- Standard Footstep NFT
- 200 TON
Total: $340
I am implementing the solution in this pull request trustwallet/assets#22801
Looks good! But I think reward for this footstep should be just the Footstep NFT, since all the work is just to change a few links and names in config and make a pull request.
It's ok. But still the fee should be paid
Looks good! But I think reward for this footstep should be just the Footstep NFT, since all the work is just to change a few links and names in config and make a pull request.
Turned out that TON was already in this repository so @PolyProgrammist just updated old info and didn't need to pay the fees.
I checked the pull request and found out that you provided the old github link newton-blockchain instead of current official ton-blockchain. So I fixed that and also opened PR, with few other additions (links):
trustwallet/assets#22826
@Hiyorimi can you please edit the reward to standard footstep NFT and approve it?
@Hiyorimi can you please edit the reward to standard footstep NFT and approve it?
Done!
Idk why but they didn't respond to my pull request :/
Maybe I did something wrong..
@PolyProgrammist Maybe you can create another PR and add all links like twitter, telegram, coingecko etc.
You can also look at my PR to see what links did I include trustwallet/assets#22826
Hi, I have already updated the code to official ton blockchain github, see the master branch
Hi, I have already updated the code to official ton blockchain github, see the master branch
@PolyProgrammist
I saw that you updated github link. I'm talking about links to telegram, twitter, coingecko, docs
@PolyProgrammist any updates?
@PolyProgrammist any updates?
Hi just to check will you be able to provide 700 twt? @Gusarich
@PolyProgrammist any updates?
Hi just to check will you be able to provide 700 twt? @Gusarich
Why? I thought you didn't need to pay the fee?
I didn't pay. But the standard process to merge pull request is to pay the fee. So in order to create the third pull request I need to know if you will be able to pay the fee @Gusarich
@Gusarich @Hiyorimi @Naltox hi could you please check PolyProgrammist/assets#3
@Gusarich @Hiyorimi @Naltox hi could you please check PolyProgrammist/assets#3
LGTM
@PolyProgrammist feel free to complete the Footstep and submit a PR
@PolyProgrammist I see the pull request to your local forked repository and it's good. But did you create a PR to original trust wallet repository with these new changes?
@Gusarich @Hiyorimi @Naltox hi could you please check PolyProgrammist/assets#3
LGTM
Could you please pay the fee as described here trustwallet/assets#23171 (comment)
Closing as completed