tonik/theme

Problem with DIRECTORY_SEPARATOR.

NautHnim opened this issue · 3 comments

NautHnim commented

I use windows OS and after install theme, i found a problem with DIRECTORY_SEPARATOR constants, when theme use asset_path function, it output the url with no separator.

Line 70, ASSETS.php:
$uri . DIRECTORY_SEPARATOR . $this->getRelativePath();

http://prntscr.com/hugboe

jedrzejchalubek commented

I've moved to use fixes slash string instead of DIRECTORY_SEPARATOR constant. It looks like PHP handles these paths correctly on both win and linux.

Can you test it out with develop branch by using "tonik/gin": "dev-develop" in your composer file?

NautHnim commented

I also add "/" instead of DIRECTORY_SEPARATOR and now tonik work perfectly.
Another question, I want to add TMGPA for require plugin and Kirki for Customizer function.
What folder I can put 2 plugins TMGPA and Kirki? any recommend?