tonioni/WinUAE

"Create 256 color palette" screenshot ripper option is a bit buggy

johnnovak opened this issue ยท 5 comments

The new "create 256 color palette" option in the screenshot ripper is a bit buggy with certain AGA palettes at least.

I displayed this test IFF in DirOpus:
Made_Nudge.zip

This is what I see on my screen:

image

And this is the resulting screenshot:
bug

So certain colours got messed up, maybe some "wraparound" bug? You will only get the bug with certain input as it seems to be colour dependent, so make sure to test with this image. Same bug on 5.0.0 and 5.1.0.

If I uncheck the "create 256 color palette" option, the colors are fine.

I can't duplicate. I loaded image in your attachment in Personal Paint (I won't use dopus, impossible to have exactly same versions of all libraries and other stuff..), hide the interface and took 256 color screen shot: screenshot was correct. Does other (much simpler) image viewers show same problem?

Also make sure "take screenshot before filtering" is ticked to get Amiga hardware level colors and image. (Shouldn't cause above problems even if enabled but usually it results in much more colors) Your attachment looks like it was already ticked because aspect ratio is different.

Also make sure "take screenshot before filtering" is ticked to get Amiga hardware level colors and image.

Yes, I have both ticked.

image

Okay, different AGA image and Deluxe Paint v5.2 this time. Disabling my CRT shader setup for the "what I see on my screen" screenshots taken outside of WinUAE to avoid confusion.

So these screenshots are taken outside of WinUAE, this is what I see on my screen:

image

image

And this is how the captured PNGs look like:

image

image

Here are the unmodified captured PNGs:

screenshots.zip

And here's the IFF file I'm using for the test:

Made_AnimalReign.zip

I'm just providing you IFF files to make it easier to reproduce the issue. But I first noticed this when taking some image captures during playing Eye of the Beholder II AGA. If you still can't reproduce it with DPaint AGA, I'm gonna give you a list of WHDLoad games that 100% manifest the issues (with savegames to make it easy for you).

I also tried your own FileMaster 2.2, but it doesn't support AGA ๐Ÿ˜„

(Sidenote: This is a slightly different A1200 config, as you can see here I'm using "Double" line mode, and in my original ticket I was using "Single", hence the squashed aspect ratio of the captured images in my first report.)

And to state the obvious: I'm pressing the Save Screenshot button in the ripper to create the screenshots.

Should be fixed now (5200b2), please confirm.

@tonioni I've tested it with a few dozens of AGA pics, and now it's perfect! Thanks! And palette index 0 is now left alone, which is a nice touch ๐Ÿ‘๐Ÿป