toomuchdesign/react-minimal-pie-chart

Labels not centered in Firefox

janhartmann opened this issue · 4 comments

janhartmann commented

Do you want to request a feature or report a bug?

A bug
...

What is the current behaviour?

Using single label is not centered
...
image

What is the expected behaviour?

Using single label is centered
...

Steps to Reproduce the Problem

  1. Open Firefox
  2. Go to https://toomuchdesign.github.io/react-minimal-pie-chart/index.html?path=/story/labels--single-label

Specifications

  • Version: 4.2.0
  • Platform: MacOS / Windwos
  • Subsystem:
toomuchdesign commented

Hi @janhartmann,
it seems that firefox doesn't play well with alignment-baseline property when applied to <text> elements.

Applying dominant-baseline: middle might solve the issue. I'll open PR asap unless you'd like to take care of it.

Cheers and thanks!

  • 👍1
janhartmann commented

No problem and thanks for this great library :-)

toomuchdesign commented

You're welcome! :)

toomuchdesign commented

Addressed in #68 even though dominant-baseline is not widely supported.