Cannot use parentNode config anymore due to HTML5 data attribute support
mikeatlas opened this issue · 2 comments
Per f5941492, the new ability to set the parentNode
instead of just the DOM document element id regressed due to line 111 still assuming the document is the container:
var uel = document.getElementById(config.id);
You might look into adding a test suite (not just demo pages), as your demo for setting parentNode
doesn't use the latest HTML5 code, which caused the regression. I really like Jasmine, personally.
You are 10000% right.
This thing is steadily growing and getting out of my hands, and I still don't have an efficient process established to test new commits.
I am a complete novice, when it comes to setting up automatic tests of any sort - I am part designer - part coder.
Google is my friend I know that, but any help on getting me up to speed with jasmine is welcome :)
Hiya,
This should work fine now. There's also a new custom node demo. There are four gauge creation cases: by constructor params and data-attribs, on DOM tree nodes, and the same for nodes outside of DOM tree.
Please check. Thanks :)